Skip to content

feat: add vue drawer navigation template to create project command#4652

Merged
elena-p merged 1 commit intomasterfrom
hristova/add-drawer-navigation-vue-template
May 28, 2019
Merged

feat: add vue drawer navigation template to create project command#4652
elena-p merged 1 commit intomasterfrom
hristova/add-drawer-navigation-vue-template

Conversation

@elena-p
Copy link
Copy Markdown
Contributor

@elena-p elena-p commented May 27, 2019

PR Checklist

What is the current behavior?

when vue flavor is selected, an app is created with the vue blank template

What is the new behavior?

when vue flavor is selected, two options are presented - Blank and SideDrawer

Fixes/Implements/Closes #4651.

@elena-p elena-p requested a review from DimitarTachev May 27, 2019 14:07
@cla-bot cla-bot bot added the cla: yes label May 27, 2019
@rosen-vladimirov
Copy link
Copy Markdown
Contributor

test cli-create

@rosen-vladimirov rosen-vladimirov self-requested a review May 28, 2019 06:21
Copy link
Copy Markdown
Contributor

@DimitarTachev DimitarTachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link
Copy Markdown
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@elena-p elena-p merged commit 6343541 into master May 28, 2019
@elena-p elena-p deleted the hristova/add-drawer-navigation-vue-template branch May 28, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add drawer navigation prompt when vue flavor is selected on tns create

3 participants